Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1931 "🤗 How to get path param before a custom verb?" #1983

Merged
merged 2 commits into from Jul 27, 2022

Conversation

ReneWerner87
Copy link
Member

Add possibility for parameters before custom verb

FIX for "🤗 How to get path param before a custom verb? #1931"
@ReneWerner87 ReneWerner87 linked an issue Jul 26, 2022 that may be closed by this pull request
@ReneWerner87 ReneWerner87 requested a review from efectn July 26, 2022 18:29
Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test case for Ctx_Params.

@ReneWerner87
Copy link
Member Author

I think we should add a test case for Ctx_Params.

not really needed
https://github.com/gofiber/fiber/pull/1983/files#diff-e65edbcd5a006378e11ec33d7b121f21a20ec2631433f0b75bfa54e11768e9caR185 tested with this line

@ReneWerner87 ReneWerner87 merged commit ff1e010 into master Jul 27, 2022
@efectn efectn deleted the Get_path_param_before_a_custom_verb_#1931_ branch July 27, 2022 06:39
trim21 pushed a commit to trim21/fiber that referenced this pull request Aug 15, 2022
…ofiber#1983)

* Add possibility for parameters before custom verb
FIX for "🤗 How to get path param before a custom verb? gofiber#1931"

* try to stabilize the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤗 How to get path param before a custom verb?
2 participants