Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 Monitor middleware doesn't work in offline environments, requires CDN-hosted resources #1936

Closed
hi019 opened this issue Jun 17, 2022 · 1 comment
Closed

馃殌 Monitor middleware doesn't work in offline environments, requires CDN-hosted resources #1936

hi019 opened this issue Jun 17, 2022 · 1 comment
Labels
馃憤 Accepting PR 馃Ч Updates

Comments

@hi019
Copy link
Contributor

hi019 commented Jun 17, 2022

Is your feature request related to a problem?
The monitor middleware can't be used on offline hosts, because it relies on external CDN's: https://github.com/gofiber/fiber/blob/master/middleware/monitor/index.go#L35-L36

Describe the solution you'd like
Monitor resources should be served by Fiber
@hi019 hi019 changed the title 馃殌 Monitor middleware requires CDN-hosted resources, doesn't work in offline environments 馃殌 Monitor middleware doesn't work in offline environments, requires CDN-hosted resources, Jun 17, 2022
@hi019 hi019 changed the title 馃殌 Monitor middleware doesn't work in offline environments, requires CDN-hosted resources, 馃殌 Monitor middleware doesn't work in offline environments, requires CDN-hosted resources Jun 17, 2022
@gaby
Copy link
Member

gaby commented Jun 17, 2022

馃憤馃徎 Thanks for reporting this. We ran into this small issue today while deploying a Fiber powered service in an offline environment.

@efectn efectn mentioned this issue Jun 28, 2022
Closed
@taheri24 taheri24 mentioned this issue Jun 29, 2022
Merged
ReneWerner87 pushed a commit that referenced this issue Jul 5, 2022
@taheri24 @efectn
add some parameters to config for supporting #1936 (#1956)
744e4da 
* add some parameters to config for supporting #1936

* remove go:embed

* apply code review  - 1956#issuecomment-1169811117

* lint

Co-authored-by: Muhammed Efe 脟etin <efectn@protonmail.com>
@efectn efectn closed this as completed Jul 8, 2022
trim21 pushed a commit to trim21/fiber that referenced this issue Aug 15, 2022
@taheri24 @efectn @trim21
add some parameters to config for supporting gofiber#1936 (gofiber#1956)
8c3b837 
* add some parameters to config for supporting gofiber#1936

* remove go:embed

* apply code review  - 1956#issuecomment-1169811117

* lint

Co-authored-by: Muhammed Efe 脟etin <efectn@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
馃憤 Accepting PR 馃Ч Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

鉁忥笍 feature: useCDN option for monitor middleware gofiber/fiber
4 participants
@gaby @ReneWerner87 @efectn @hi019