Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for QueryParser for SetParserDecoder #1562

Merged

Conversation

rockcreation7
Copy link
Contributor

Please provide enough information so that others can review your pull request:

Adding Test case for QueryParser With SetParserDecoder for new possibility

Explain the details for making this change. What existing problem does the pull request solve?

Continue on - #1555

Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87
Copy link
Member

image

@ReneWerner87
Copy link
Member

@rockcreation7 please check the unittests -> maybe both tests influence each other, you should reset the adjustments after the test again

@rockcreation7
Copy link
Contributor Author

Thanks, let me check

@rockcreation7
Copy link
Contributor Author

will update

@rockcreation7 rockcreation7 marked this pull request as draft October 4, 2021 15:53
debug unit test  - may close this pull request for cleaner commit
@rockcreation7 rockcreation7 marked this pull request as ready for review October 4, 2021 16:02
@ReneWerner87 ReneWerner87 merged commit c098ada into gofiber:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants