New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for QueryParser for SetParserDecoder #1562
Merged
ReneWerner87
merged 10 commits into
gofiber:master
from
rockcreation7:OptionToOverideFormDecoderSetting
Oct 5, 2021
Merged
Add test case for QueryParser for SetParserDecoder #1562
ReneWerner87
merged 10 commits into
gofiber:master
from
rockcreation7:OptionToOverideFormDecoderSetting
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔥 Feature : SetBodyParserDecoder map all option to form decoder, use with BodyParserConfig, BodyParserType 🚨 Test : Test_Ctx_BodyParser_WithSetBodyParserDecoder
BodyParserType > ParserType bodyParserConfig > parserConfig BodyParserConfig > ParserConfig
@rockcreation7 please check the unittests -> maybe both tests influence each other, you should reset the adjustments after the test again |
Thanks, let me check |
will update |
debug unit test - may close this pull request for cleaner commit
ReneWerner87
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Adding Test case for QueryParser With SetParserDecoder for new possibility
Explain the details for making this change. What existing problem does the pull request solve?
Continue on - #1555
Commit formatting
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/