♻️ Option to overide form decoder setting - Rename function #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔥 Feature : SetBodyParserDecoder map all option to form decoder, use with BodyParserConfig, BodyParserType 🚨 Test : Test_Ctx_BodyParser_WithSetBodyParserDecoder
BodyParserType > ParserType bodyParserConfig > parserConfig BodyParserConfig > ParserConfig
|
Thx, there are merged conflicts, could you please update the branch And maybe provide also a new test case where we use the new possibilities for the query parser. |
|
https://github.com/gofiber/docs Can you also add a block for the new possibilities in the documentation repository? |
|
I will first add the docs, and follow up a new test case for the query parser. |
|
Added block of doc on use with BodyPauser, may update again after QueryPauser test case |
|
I think it can be integrate with app config, what you guys think? or just let it as stand alone function. |
|
Standalone is okay for now |
ReneWerner87
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Rename function - SetBodyParserDecoder to SetParserDecoder
Explain the details for making this change. What existing problem does the pull request solve?
@ReneWerner87 : rename it a bit, because the decoder is used by the query parser and body parser
#1100
Commit formatting
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/