Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📒 Update Spanish documentation #1554

Merged
merged 2 commits into from Oct 2, 2021
Merged

📒 Update Spanish documentation #1554

merged 2 commits into from Oct 2, 2021

Conversation

ivanvc
Copy link
Contributor

@ivanvc ivanvc commented Sep 30, 2021

Please provide enough information so that others can review your pull request:

Improve Spanish translation by fixing some spelling issues, and vague translations. Also, finish several sections where the translation was missing.

Copy link

@TheAmniel TheAmniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small translation errors

.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
.github/README_es.md Outdated Show resolved Hide resolved
Copy link

@NotKirzu NotKirzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small fix on a word

.github/README_es.md Outdated Show resolved Hide resolved
@ivanvc
Copy link
Contributor Author

ivanvc commented Oct 1, 2021

Thanks for the thorough review @DannyxT and @NotKirzu!

I did address your comments, and also ran a spellcheck (I was using GitHub's website rather than my local environment, and missed many spelling errors 🤦)

@hi019 hi019 merged commit 95a9e50 into gofiber:master Oct 2, 2021
@hi019
Copy link
Contributor

hi019 commented Oct 2, 2021

Thanks, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants