Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request 馃殌: Skip successful requests option for ratelimit middleware #1512

Closed
pateljoel opened this issue Aug 30, 2021 · 2 comments 路 Fixed by #1542
Closed

Feature Request 馃殌: Skip successful requests option for ratelimit middleware #1512

pateljoel opened this issue Aug 30, 2021 · 2 comments 路 Fixed by #1542
Labels
馃憤 Accepting PR 鉁忥笍 Feature

Comments

@pateljoel
Copy link

It would be nice if it is possible for an option to skip successful requests much like the express rate limit library for node:

express-rate-limit#skipsuccessfulrequests

Thanks.
@welcome
Copy link

welcome bot commented Aug 30, 2021

Thanks for opening your first issue here! 馃帀 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

feel free to create a pull request containing the new option at the limiter middleware

@aliereno aliereno mentioned this issue Sep 25, 2021
Merged
@ReneWerner87 ReneWerner87 linked a pull request Oct 6, 2021 that will close this issue
馃敟 Feature: limiter middleware new skip options implemented #1542
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
馃憤 Accepting PR 鉁忥笍 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃敟 Feature: limiter middleware new skip options implemented
2 participants
@ReneWerner87 @pateljoel