🐛 Static path with trailing slashes doesn't work!

[imraan-go]

Fiber version
v2.17.0
Issue description
Static path with trailing slashes does not work! When path ends with slash like /docs/ or docs/ , the path is not found!
Code snippet

package main

import "github.com/gofiber/fiber/v2"

func main() {
  app := fiber.New()
app.Static("/docs", "./docs/slate/build/") // -> http://localhost:3000/docs  Works.
app.Static("/docs/", "./docs/slate/build/") // -> http://localhost:3000/docs/ Doesn't work! 404 Not found



  // Steps to reproduce

  log.Fatal(app.Listen(":3000"))
}

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[IGLOU-EU]

Even if you try to force StrictRouting to false in Config struct ?
https://pkg.go.dev/github.com/gofiber/fiber/v2#Config

[imraan-go]

Even if you try to force StrictRouting to false in Config struct ?
https://pkg.go.dev/github.com/gofiber/fiber/v2#Config

StrictRouting is false by default! This has nothing to do with strict routing. The problem is with Static method. app.Get("/products/", SearchProducts) This works perfectly fine with default settings.I can browse http://localhost/products/ But app.Static("/docs/", "./docs/slate/build/") shows 404 Not found.

[ReneWerner87]

could be that the error lies there

https://github.com/valyala/fasthttp/blob/master/fs.go#L978

[imraan-go]

This is not related to fasthttp. I just tried debugging it, looks like the handler does not get called at all in handler variable in registerStatic method. So seems like fiber is unable to set the router properly when static path ends with slashes.

[fufuok]

May be fixed by #1538

[fufuok]

package main

import (
	"github.com/gofiber/fiber/v2"
)

func main() {
	app := fiber.New()
	app.Static("/web", "./web")
	app.Listen(":3000")
}

go.mod

module tmp_static_web

go 1.15

require github.com/gofiber/fiber/v2 v2.19.1-0.20211001105148-b94870d8865b

tmp_static_web.211001.zip

[fufuok]

If you want to use trailing slash to register static file routing, then you may need such modification.

@ReneWerner87 if necessary, I can PR.

demo

package main

import (
	"github.com/gofiber/fiber/v2"
)

func main() {
	app := fiber.New()
	app.Static("/static", "./public", fiber.Static{
		Browse: true,
	})
	app.Static("/test_static/", "./public", fiber.Static{
		Browse: true,
	})
	app.Static("/web", "./public/web")
	app.Static("/test_web/", "./public/web")
	app.Listen(":3000")
}

go.mod

module tmp_static_trailing_slash

go 1.15

require github.com/gofiber/fiber/v2 v2.19.0

replace github.com/gofiber/fiber/v2 v2.19.0 => github.com/fufuok/fiber/v2 v2.19.1-0.20211001150354-c126d46683c1

You can visit the following URL:

• http://127.0.0.1:3000/static
• http://127.0.0.1:3000/static/
• http://127.0.0.1:3000/test_static
• http://127.0.0.1:3000/test_static/
• http://127.0.0.1:3000/web
• http://127.0.0.1:3000/web/
• http://127.0.0.1:3000/test_web
• http://127.0.0.1:3000/test_web/

demo code

tmp_static_trailing_slash_fixed.211001.zip

[suntong]

Haha, reported that before in #705, which had been closed without giving any reason.
Thanks @fufuok for finally make it works. Thanks!