From a9ddef7a208f32351a15399198378382a6022558 Mon Sep 17 00:00:00 2001 From: kinggo Date: Sun, 11 Dec 2022 02:28:39 +0800 Subject: [PATCH] optimize: add more detail error message in serverErrorHandler (#2267) --- app.go | 2 +- app_test.go | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app.go b/app.go index 504a1efc50..9b6312a043 100644 --- a/app.go +++ b/app.go @@ -1031,7 +1031,7 @@ func (app *App) serverErrorHandler(fctx *fasthttp.RequestCtx, err error) { } else if strings.Contains(err.Error(), "timeout") { err = ErrRequestTimeout } else { - err = ErrBadRequest + err = NewError(StatusBadRequest, err.Error()) } if catch := app.ErrorHandler(c, err); catch != nil { diff --git a/app_test.go b/app_test.go index 7d532f3143..d414bd27bf 100644 --- a/app_test.go +++ b/app_test.go @@ -245,6 +245,16 @@ func Test_App_ErrorHandler_RouteStack(t *testing.T) { utils.AssertEqual(t, "1: USE error", string(body)) } +func Test_App_serverErrorHandler_Internal_Error(t *testing.T) { + app := New() + msg := "test err" + c := app.AcquireCtx(&fasthttp.RequestCtx{}) + defer app.ReleaseCtx(c) + app.serverErrorHandler(c.fasthttp, errors.New(msg)) + utils.AssertEqual(t, string(c.fasthttp.Response.Body()), msg) + utils.AssertEqual(t, c.fasthttp.Response.StatusCode(), StatusBadRequest) +} + func Test_App_Nested_Params(t *testing.T) { app := New()