Add PoolArray::to_vec(), improve doc around read()/write() #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806.
I noticed that the documentation around the
read()
andwrite()
methods was a bit lacking, and tried to make it a bit easier to understand. Also moved traitimpl
s after the inherentimpl
.I'm not 100% sure that we really need
to_vec()
. It's nice as a convenience, but it may cause people to do things likeinstead of going via
read()
. After all,read().to_vec()
is not much longer.On the other hand, we already have
PoolArray::from_vec()
, so it's somewhat symmetric.I'd be happy for some input on that.