Add a name optional argument to #[export]
#734
Conversation
This allows exporting methods to godot under a different name. Implements godot-rust#732
gdnative-derive/src/methods.rs
Outdated
| let name_string = match args.name_override { | ||
| Some(name_override) => name_override, | ||
| None => name.to_string(), | ||
| }; |
There was a problem hiding this comment.
Could be written more concisely as args.name_override.unwrap_or_else(|| name.to_string()), I believe?
There was a problem hiding this comment.
Much better, thanks!
gdnative-derive/src/methods.rs
Outdated
| // NOTE: We take advantage of rust identifiers following | ||
| // the same syntax rules as Godot method identifiers. See: | ||
| // https://docs.godotengine.org/en/stable/getting_started/scripting/gdscript/gdscript_basics.html#identifiers |
There was a problem hiding this comment.
I wonder if it's really required that a method name is a valid identifier. We know for sure that properties can have non-identifier names: the property name of the controller of an AnimationTree is "parameters/playback", for example. I guess a non-identifier name can still be called using call()? If so, is it still necessary to check this here?
There was a problem hiding this comment.
I've just checked and indeed exported methods don't need to be valid identifiers, so I've lifted the restriction and now any string can be an exported method.
|
@toasteater Just made a new commit addressing your comments. Let me know if there's anything else! |
|
Build succeeded: |
This allows exporting methods to godot under a different name.
This commit implements the feature described in #732