Use a private uninhabited type for Export impls without hints #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it no longer a breaking change to add hints for these types later, since the type can't be constructed, and can't be named except as an associated type, so it could not be used in a way that would break if we replace it with something else in safe code.
ghost
added
feature
halzy
approved these changes
Feb 5, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No PRs in our godot-rust repo??? Time to change that!
This makes it no longer a breaking change to add hints for these types later, since the type can't be constructed, and can't be named except as an associated type, so it could not be used in a way that would break if we replace it with something else in safe code.
Close #684