Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run optional initialization/cleanup code automatically if the relevant feature is enabled #805

Open
chitoyuu opened this issue Oct 26, 2021 · 0 comments
Open

Run optional initialization/cleanup code automatically if the relevant feature is enabled #805

chitoyuu opened this issue Oct 26, 2021 · 0 comments
Labels
c: core Component: core (mod core_types, object, log, init, ...) quality-of-life No new functionality, but improves ergonomics/internals
Milestone
v0.12.0

Comments

@chitoyuu
Copy link
Contributor

chitoyuu commented Oct 26, 2021 •
edited

PR #804 introduces the async feature which requires additional initialization and cleanup outside gdnative-core to work properly. This cannot currently be automatically done, since the async crate also depends on generated bindings, and cannot be seen from -core.

Related: the crates mentioned in #350 can also be used to implement this.
@chitoyuu chitoyuu mentioned this issue Oct 26, 2021
Merged
@Bromeon Bromeon added bug c: core Component: core (mod core_types, object, log, init, ...) quality-of-life No new functionality, but improves ergonomics/internals and removed bug labels Oct 26, 2021
@Bromeon Bromeon added this to the v0.11 milestone Nov 1, 2021
@chitoyuu chitoyuu modified the milestones: unplanned, v0.12.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: core Component: core (mod core_types, object, log, init, ...) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
2 participants
@Bromeon @chitoyuu