feat(status): custom status codes #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindilevich would you mind taking it from here and create a PR that passes CI? sadly, I cannot find the time to finish this up |
Merged
|
@gergelyke, tried to overcome the failing tests with #191 |
|
@rxmarbles, any chance you can take a look at #191, which fixes this PR, and adds tests and typings, please? |
* Revert "feat(status): custom status codes" This reverts commit 522df64. * Added statusOk and statusError to configuration The new configuration properties: statusOk and statusError will allow to globally configure the HTTP codes, used to respond with on a successful or an unsuccessful healthcheck respectively. An unsuccessful healthcheck may override the global statusError property by setting the statusCode property on the Error object. * Added typings for statusOk and statusError
rxmarbles
approved these changes
Jun 4, 2021
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.