Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expose an internal state to health checks #185

Merged
merged 4 commits into from May 21, 2021
Merged

Feature: Expose an internal state to health checks #185

merged 4 commits into from May 21, 2021

Conversation

okv
Copy link
Contributor

@okv okv commented May 18, 2021

This PR implements #184

@gergelyke
Copy link
Collaborator

Looks great, thanks @okv ! Would you mind updating the TS types as well? Not a big deal if not, I'll take care of it in a follow up pr in that case

Let me know what you prefer

@okv
Copy link
Contributor Author

okv commented May 19, 2021

@gergelyke please update it

@okv
Copy link
Contributor Author

okv commented May 20, 2021

Hey @gergelyke ! Is there any chance that this PR will be merged? 😃

@gergelyke gergelyke merged commit ba3f67f into godaddy:main May 21, 2021
@github-actions
Copy link

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@okv okv deleted the feat/expose-internal-state-to-health-checks branch May 21, 2021 08:05
@okv
Copy link
Contributor Author

okv commented May 21, 2021

Awesome news 🚀 thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants