Support passing error objects to HealthCheckError #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyke
reviewed
Mar 9, 2021
…ADME, updates types with optional healthChecks variables
|
@gergelyke take a look at that and tell me what you think. FYI the types for optional variables didn't need to be a union, we just need to specify |
|
thanks @chriswiggins 🙇 |
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through the README, one would assume that by using the custom
HealthCheckErrorclass we'd be able to pass errors caught in thePromise.alland see these returned in the result.As errors passed to
JSON.stringifyjust result in an empty object being output (normally), a custom replacer function is now included to fix thatLet me know if there's anything else that needs to be done to have this included. Terminus has been fantastic in our k8s environment!