New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quoted map key #328
Fix quoted map key #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does look easier, however it looks like this will break on the following valid yaml:
a:
"b" : 1
"c": 2
It would be good to add this as a test case, I should have added it in mine.
My proposal in #327 had something to check if the buffer is currently all whitespace, maybe including this would fix it?
@braydonk Thank you for your review ! You are right, I will try to make a fix that will take care of whitespace. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 75.63% 75.63%
=======================================
Files 13 13
Lines 4359 4359
=======================================
Hits 3297 3297
Misses 819 819
Partials 243 243 |
DONE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good strategy! Looks good to me.
@braydonk Thank you for your review !! Merged. |
fix #301
ref #327