Fix resusing process of scanning context #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 75.63% 75.63%
=======================================
Files 13 13
Lines 4359 4359
=======================================
Hits 3297 3297
Misses 819 819
Partials 243 243 |
kortschak
reviewed
Nov 14, 2022
Comment on lines
+58
to
+62
| c.isRawFolded = false | ||
| c.isSingleLine = true | ||
| c.isLiteral = false | ||
| c.isFolded = false | ||
| c.literalOpt = "" |
There was a problem hiding this comment.
Individually zeroing fields keeps open the potential for this class of bug in the future if new fields are added to *Context. This is why the original proposal was to use a single assignment to *c only retaining the non-zero valued fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #316