fix: Avoid truncating last char from folded strings #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in goccy#433, if the last character of a folded string is the very last character in the file (no trailing whitespace), it's not included the token's `Value`. While fixing this, I also noticed that the column information for the folded and literal strings were the end rather than the beginning. I've (hopefully) fixed that as well. Fixes goccy#433 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #433, if the last character of a folded string is the
very last character in the file (no trailing whitespace), it's not
included in the token's
Value.While fixing this, I also noticed that the column information for the
folded and literal strings were for the end rather than for the beginning.
I've (hopefully) fixed that as well.
Fixes #433