Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentGroupNode Type() returns CommentType #411

Open
jbutA opened this issue Dec 12, 2023 · 0 comments
Open

CommentGroupNode Type() returns CommentType #411

jbutA opened this issue Dec 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jbutA
Copy link

jbutA commented Dec 12, 2023

Describe the bug
CommentGroupNode Type() function returns CommentType.

To Reproduce
Yaml:
https://go.dev/play/p/dRb5T1r4Irl

(but it's clear from the source I suppose: https://github.com/goccy/go-yaml/blob/0640a158e99023787bc503fd4476e472d804c3a3/ast/ast.go#L1853C26-L1853C26)

Expected behavior
If the intention is that it's easier to handle Comment and CommentGroups as the same type, then perhaps this is expected. But I don't believe that's clear at the moment.

Screenshots
N/A

Version Variables

  • Go version: 1.21
  • go-yaml's Version: v1.11.2

Additional context
N/A

@jbutA jbutA added the bug Something isn't working label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant