Comment Map: Only parses comments on the first key of each map

[coxley]

It's entirely possible that I'm using this incorrectly, but it seems that yaml.CommentToMap(cm) only retrieves comments if they're on the first key for each map. Should I be decoding to something other than a MapSlice?

package main

import (
	"bytes"
	"fmt"
	"io"

	"github.com/goccy/go-yaml"
)

var contents = []byte(`
top:
  # This comment is captured
  first: true
  # But not this one
  second:
	# But this one is
    first: true
    # But not this one
    second: true
    # Neither this
    third: true
`)

func main() {
	cm := yaml.CommentMap{}
	dec := yaml.NewDecoder(bytes.NewReader(contents), yaml.UseOrderedMap(), yaml.CommentToMap(cm))

	for {
		var mslice yaml.MapSlice
		err := dec.Decode(&mslice)
		if err == io.EOF {
			break
		}

		if err != nil {
			panic(err)
		}
	}

	for _, comment := range cm {
		fmt.Println(comment.Texts)
	}
}

// ➜ go run main.go
// [ But this one is]
// [ This comment is captured]

I need to edit some values in hundreds of files, preserving as much as I can. This is blocking that. 😅

[coxley]

Looks like it's the combination of UseOrderedMap and CommentToMap that causes it. Works fine without preserving ordering...

[coxley]

Submitted #346 to address.