Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, utf-8 support is broken, because of golang behavior when looping with a range on string in ast
readNode
functiongo-yaml/ast/ast.go
Line 269 in e4f32a2
In this case, range loop over string runes and not string bytes. As a consequence, the resulting buffer bytes does not correspond to the string bytes themselves.
See the results on https://go.dev/play/p/5pWTN0y4vUj
Fortunately, a simple byte casting fix the issue :)
A test has been provided with obscure utf-8 characters.