Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confusing nil in direct interface with typed nil #377

Merged
merged 2 commits into from Jul 4, 2022

Conversation

orisano
Copy link
Sponsor Contributor

@orisano orisano commented Jul 2, 2022

fix #376

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #377 (884b8db) into master (27bd0f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   79.92%   79.93%           
=======================================
  Files          52       52           
  Lines       17561    17565    +4     
=======================================
+ Hits        14036    14040    +4     
  Misses       2957     2957           
  Partials      568      568           

@orisano
Copy link
Sponsor Contributor Author

orisano commented Jul 4, 2022

ping @goccy

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@goccy goccy merged commit 1468eef into goccy:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: struct with map (the only one field) encoded to null
4 participants