From d2790005a2ff33b3e9e128ce09a9591ba5e44e75 Mon Sep 17 00:00:00 2001 From: Patrik Date: Mon, 28 Jun 2021 15:40:45 +0200 Subject: [PATCH] fix: log model values everywhere (#656) Some SQL logs were missing the values as argument. This adds all places --- dialect_cockroach.go | 2 +- dialect_common.go | 4 ++-- dialect_postgresql.go | 2 +- dialect_sqlite.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dialect_cockroach.go b/dialect_cockroach.go index d8dd0a08..9e933336 100644 --- a/dialect_cockroach.go +++ b/dialect_cockroach.go @@ -81,7 +81,7 @@ func (p *cockroach) Create(s store, model *Model, cols columns.Columns) error { } else { query = fmt.Sprintf("INSERT INTO %s DEFAULT VALUES returning %s", p.Quote(model.TableName()), model.IDField()) } - log(logging.SQL, query) + log(logging.SQL, query, model.Value) stmt, err := s.PrepareNamed(query) if err != nil { return err diff --git a/dialect_common.go b/dialect_common.go index 0905b049..79d0d190 100644 --- a/dialect_common.go +++ b/dialect_common.go @@ -53,7 +53,7 @@ func genericCreate(s store, model *Model, cols columns.Columns, quoter quotable) cols.Remove(model.IDField()) w := cols.Writeable() query := fmt.Sprintf("INSERT INTO %s (%s) VALUES (%s)", quoter.Quote(model.TableName()), w.QuotedString(quoter), w.SymbolizedString()) - log(logging.SQL, query) + log(logging.SQL, query, model.Value) res, err := s.NamedExec(query, model.Value) if err != nil { return err @@ -81,7 +81,7 @@ func genericCreate(s store, model *Model, cols columns.Columns, quoter quotable) w := cols.Writeable() w.Add(model.IDField()) query := fmt.Sprintf("INSERT INTO %s (%s) VALUES (%s)", quoter.Quote(model.TableName()), w.QuotedString(quoter), w.SymbolizedString()) - log(logging.SQL, query) + log(logging.SQL, query, model.Value) stmt, err := s.PrepareNamed(query) if err != nil { return err diff --git a/dialect_postgresql.go b/dialect_postgresql.go index 3590141e..ad5b2350 100644 --- a/dialect_postgresql.go +++ b/dialect_postgresql.go @@ -68,7 +68,7 @@ func (p *postgresql) Create(s store, model *Model, cols columns.Columns) error { } else { query = fmt.Sprintf("INSERT INTO %s DEFAULT VALUES returning %s", p.Quote(model.TableName()), model.IDField()) } - log(logging.SQL, query) + log(logging.SQL, query, model.Value) stmt, err := s.PrepareNamed(query) if err != nil { return err diff --git a/dialect_sqlite.go b/dialect_sqlite.go index 47bc3e28..c340afa8 100644 --- a/dialect_sqlite.go +++ b/dialect_sqlite.go @@ -82,7 +82,7 @@ func (m *sqlite) Create(s store, model *Model, cols columns.Columns) error { } else { query = fmt.Sprintf("INSERT INTO %s DEFAULT VALUES", m.Quote(model.TableName())) } - log(logging.SQL, query) + log(logging.SQL, query, model.Value) res, err := s.NamedExec(query, model.Value) if err != nil { return err