Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in name.Folder() #24

Closed
tobiashienzsch opened this issue Sep 5, 2019 · 1 comment · Fixed by #60
Closed

Bug in name.Folder() #24

tobiashienzsch opened this issue Sep 5, 2019 · 1 comment · Fixed by #60
Assignees
@sio4
Labels
breaking change This feature/fix introduces breaking changes s: fixed was fixed or solution offered

Comments

@tobiashienzsch
Copy link

See gobuffalo/buffalo issue #1769.

The problem seems to be in /flect/name/folder.go:22

Testcase
This testcase should pass:

{"NameOthername", "name_othernames"},

but it produces:

"name/othername"
@tobiashienzsch tobiashienzsch mentioned this issue Sep 5, 2019
Closed
@sio4 sio4 self-assigned this Sep 3, 2022
@sio4 sio4 added s: triage Some tests need to be run to confirm the issue breaking change This feature/fix introduces breaking changes labels Sep 3, 2022
@sio4
Copy link
Member

sio4 commented Sep 3, 2022 •
edited

Indeed, this behavior does not help Buffalo's generator as the original issue explained. However, from the perspective of Flect, it can be a breaking change. Will work on this soon.

sio4 added a commit that referenced this issue Sep 3, 2022
@sio4
fixed #24 by adjusting the function's conditions
9821b8b
@sio4 sio4 mentioned this issue Sep 3, 2022
Merged
@sio4 sio4 closed this as completed in a5e963f Sep 3, 2022
@sio4 sio4 closed this as completed in #60 Sep 3, 2022
@sio4 sio4 added s: fixed was fixed or solution offered and removed s: triage Some tests need to be run to confirm the issue labels Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sio4 sio4

Labels
breaking change This feature/fix introduces breaking changes s: fixed was fixed or solution offered
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #24 by adjusting the function's conditions gobuffalo/flect
2 participants
@sio4 @tobiashienzsch