Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tableize: underscore before pluralize #21

Closed
dvli2007 opened this issue Apr 13, 2019 · 0 comments · Fixed by #23
Closed

Tableize: underscore before pluralize #21

dvli2007 opened this issue Apr 13, 2019 · 0 comments · Fixed by #23

Comments

@dvli2007
Copy link

dvli2007 commented Apr 13, 2019 •
edited

Due to the complexity of the English language, it seems that Pluralize may sometimes not preserve the capital cases in a name (as shown by this issue: #20).

Due to this fact, it would be safer for Tableize to perform Underscore() before Pluralize() (affected line of code here).

For example, if I have a struct named "BigPerson", I would expect that tableized name to be "big_people". Currently, Tableize("BigPerson") -> "bigpeople", because the Pluralize step does not preserve the capital P. Underscoring first would produce the expected "big_people" result.
stanislas-m added a commit that referenced this issue Aug 20, 2019
@stanislas-m
Fix tablize with camel case
e56311d 
Fixes #21.
@stanislas-m stanislas-m mentioned this issue Aug 20, 2019
Merged
stanislas-m added a commit that referenced this issue Aug 21, 2019
@stanislas-m
Fix tablize with camel case (#23)
3a6917a 
Fixes #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tablize with camel case gobuffalo/flect
1 participant
@dvli2007