Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

process: preparing go1.18 support, step 1 - package level testing #2263

Closed
29 tasks done
Tracked by #2264
sio4 opened this issue May 13, 2022 · 3 comments
Closed
29 tasks done
Tracked by #2264

process: preparing go1.18 support, step 1 - package level testing #2263

sio4 opened this issue May 13, 2022 · 3 comments
Assignees
Labels
proposal A suggestion for a change, feature, enhancement, etc s: fixed was fixed or solution offered

Comments

@sio4
Copy link
Member

sio4 commented May 13, 2022

As a part of "preparing go1.18 support", I am now updating test workflows for all major packages. This will ensure that those packages are fine with the new version of go.

Buffalo core engine and dependencies

CLI, the major plugins, and packages used in the created app

@sio4 sio4 added the proposal A suggestion for a change, feature, enhancement, etc label May 13, 2022
@sio4 sio4 self-assigned this May 13, 2022
@sio4
Copy link
Member Author

sio4 commented May 14, 2022

Done. The transition for all current active packages was finished. Thank you @paganotoni for your quick and strong support!

IMO, the following two packages should be included in this process as they were created as the new structure of the plugin/generator concept, but skip them now.

@sio4 sio4 closed this as completed May 14, 2022
@paganotoni
Copy link
Member

paganotoni commented May 14, 2022

This is great @sio4. I think this will reduce a lot of work when 1.19 arrives. It may be time now to start sunsetting the v1.16 support. The good news is that all this should be easier after the work you've done organizing our repos. Thanks for that.

@sio4
Copy link
Member Author

sio4 commented May 14, 2022

(missing) closing note:

IMPORTANT:

Since database-related tests are complex and different from the standard, the following two packages still use their own test workflows. I hope we can make another standard for the database support, but now we keep the original tests and just fixed the version of golang.

@sio4 sio4 added the s: fixed was fixed or solution offered label Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal A suggestion for a change, feature, enhancement, etc s: fixed was fixed or solution offered
Projects
None yet
Development

No branches or pull requests

2 participants