From 7e9c2771b1263f23e1015355623e1bded59869ca Mon Sep 17 00:00:00 2001 From: Antonio Pagano <645522+paganotoni@users.noreply.github.com> Date: Fri, 1 Nov 2019 15:43:14 -0500 Subject: [PATCH] Updates GolangCI lint (#1823) * changing plural to be singular on the modules variable * Updates GolangCI lint It seems that GolangCI-lint has some issues with Go 1.13 mentioned [here](https://github.com/golangci/golangci-lint/issues/659). This PR updates the version we're using. * adding correct version to slim dockerfile --- Dockerfile.build | 2 +- Dockerfile.slim.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile.build b/Dockerfile.build index 8a5b6d84a..76b095cc4 100644 --- a/Dockerfile.build +++ b/Dockerfile.build @@ -26,7 +26,7 @@ RUN go get -tags sqlite -v -u github.com/gobuffalo/pop \ && rm -rf $GOPATH/src && mkdir -p $BP # Install golangci -RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0 +RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.21.0 WORKDIR $BP diff --git a/Dockerfile.slim.build b/Dockerfile.slim.build index 051547781..008e4f3a3 100644 --- a/Dockerfile.slim.build +++ b/Dockerfile.slim.build @@ -24,7 +24,7 @@ RUN go get -u github.com/golang/dep/cmd/dep \ && go get -v -u github.com/gorilla/sessions \ && go get -v -u golang.org/x/vgo -RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0 +RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.21.0 RUN npm i -g --no-progress yarn \