Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment notice unaware of updated repo state #909

Open
wass3rw3rk opened this issue Feb 2, 2024 · 0 comments
Open

deployment notice unaware of updated repo state #909

wass3rw3rk opened this issue Feb 2, 2024 · 0 comments
Labels
area/ui Indicates a change to the UI bug Indicates a bug

Comments

@wass3rw3rk
Copy link
Member

Description

This notice when adding a deployment is nice, but doesn't remove itself once deployment:created event is enabled.

image

to reproduce:

  1. enable repo
  2. go to deployments page to add a deployment
  3. you will see the above notice
  4. navigate to repo settings
  5. enable deployment:created event
  6. return to add a deployment form
  7. notice is still shown even though it is incorrect now

expected:

notice should disappear once the event is enabled

i would propose the following tweaks:

  1. rephrase to something like "To trigger builds for deployments, enable a 'Deployment' event on the Settings page for this repo." (or something similar)
  2. make deployments aware of updated repo state

Value

reduce confusion/friction; better ux when adding a deployment via ui

Useful Information

  1. What is the output of vela --version?

v0.23.0-rc

  1. What operating system is being used?
  1. Any other important details?
@wass3rw3rk wass3rw3rk added bug Indicates a bug area/ui Indicates a change to the UI labels Feb 2, 2024
@wass3r wass3r changed the title add deployment notice unaware of updated repo state deployment notice unaware of updated repo state Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Indicates a change to the UI bug Indicates a bug
Projects
None yet
Development

No branches or pull requests

1 participant