Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.18 #501

Closed
kneal opened this issue Feb 16, 2022 · 4 comments
Closed

Update to Go 1.18 #501

kneal opened this issue Feb 16, 2022 · 4 comments
Labels
enhancement Indicates an improvement to a feature

Comments

@kneal
Copy link

kneal commented Feb 16, 2022

Description

The new Go version is coming out soon and we should update after the first minor patch has been released. Additionally, there are some formatting changes to encourage people to use any instead of interface{}. We should try and get a new linter added to check for that in the Go files.

Value

Helps use get the latest and greatest security/feature updates and will help our code look like the community expectations.

Definition of Done

  • all Go repos have been updated to 1.18.x
  • linter has a check for interface{} to any (if it exists of course)
@kneal kneal added the enhancement Indicates an improvement to a feature label Feb 16, 2022
@wass3r
Copy link
Collaborator

wass3r commented Mar 3, 2022

additionally, we might be benefit from utilizing runtime/debug.ReadBuildInfo and maybe some of the new strings functions, and perhaps the new fuzzing ability for tests?

ref: https://tip.golang.org/doc/go1.18

@kneal
Copy link
Author

kneal commented Mar 3, 2022

The fuzzing being in the STL code be useful in compiler as well. I think that would take some research and implantation experimentation tho.

@wass3r
Copy link
Collaborator

wass3r commented Mar 16, 2022

relevant: golangci/golangci-lint#2649 - looks like we need to wait for them to support 1.18

@wass3r
Copy link
Collaborator

wass3r commented Sep 8, 2023

we are on 1.19+

@wass3r wass3r closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

No branches or pull requests

2 participants