Fix copying TypeParams #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug where the TypeParams weren't being properly copied but
rather continuing the use the source value.
The code:
```
cp := *x
if typeParams := typeparams.ForFuncType(x); typeParams != nil {
*typeparams.ForFuncType(&cp) = *FieldList(typeParams)
}
```
cp.TypeParams which typeparams.ForFyncType returns is still
x.TypeParams. Then the `*typeparams.ForFuncType(&cp)` overwrites it a
copy thus modifying the original slice.
This issue causes a data race which showed up in golangci-lint and often
caused a panic.
The only way around this I found was to have copies of the function for
different versions of Go since the typeparam package doesn't have a way
to set the TypeParams field.
|
Thanks for the PR! Not sure should we care about older Go versions but as you've fixed let's keep it. |
quasilyte
approved these changes
Jan 21, 2023
|
hello @quasilyte and @cristaloleg do you plan to create a release with the fix in the following days? |
|
Thanks @quasilyte |
|
thank you @quasilyte ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where the TypeParams weren't being properly copied but rather continuing the use the source value.
The code:
cp.TypeParams which typeparams.ForFyncType returns is still x.TypeParams. Then the
*typeparams.ForFuncType(&cp)overwrites it a copy thus modifying the original slice.This issue causes a data race which showed up in golangci-lint and often caused a panic.
The only way around this I found was to have copies of the function for different versions of Go since the typeparam package doesn't have a way to set the TypeParams field.