fixes #2831, circular dependency issue #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My approach was to track what schemas, based off of location, has already been compared. This makes it where we can complete the DIFF on a specs that have circular references as expected. |
casualjim
requested changes
Sep 8, 2022
fixtures/diff/refcircular.v2.json
Outdated
| "A1": { | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { "type": "integer" },` |
|
Gahh, my bad, removed! |
casualjim
approved these changes
Sep 9, 2022
casualjim
force-pushed
the
circular-ref-fix
branch
from
8515d2a
to
9d5139b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.