Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conncheck: move var declarations into closure #997

Merged
merged 1 commit into from Sep 7, 2019
Merged

conncheck: move var declarations into closure #997

merged 1 commit into from Sep 7, 2019

Conversation

julienschmidt
Copy link
Member

Description

Reduces the number of heap allocations caused by the connection check.

Updates #996

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.5.0 milestone Sep 6, 2019
@julienschmidt julienschmidt merged commit b2c03bc into master Sep 7, 2019
@julienschmidt julienschmidt deleted the conncheck-alloc branch September 7, 2019 12:21
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
conncheck: move var declarations into closure (go-sql-driver#997)
231bc34
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
conncheck: move var declarations into closure (go-sql-driver#997)
d004858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienschmidt @methane