move tls/pubkey object creation to Config.normalize() #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the driver.Connector interface you can skip using string based DSNs and use a Config object directly with Connector. However the logic to create the tls.Config is only found in parseDSNParams. This keeps the string parsing logic in parseDSNParams but moves the tls generation logic into Config.normalize. This is still less than ideal since we cannot directly pass in tls.Config into Config and have it be used, but it is sill backwards compatable. In the future this should be revisited to be able to use a custome tls.Config passed directly in without string parsing/registering.
Like the tlsConfig. pubKey was only set when the dsn was parsed. With Connector interface DSNs are not longer needed so this moves it to normalize which will be called when the connector is initialized.
nemith
changed the title
Increase the test coverage of dsn.go
|
Ping? |
methane
approved these changes
May 10, 2019
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
…ver#958) This is still less than ideal since we cannot directly pass in tls.Config into Config and have it be used, but it is sill backwards compatable. In the future this should be revisited to be able to use a custome tls.Config passed directly in without string parsing/registering.
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
…ver#958) This is still less than ideal since we cannot directly pass in tls.Config into Config and have it be used, but it is sill backwards compatable. In the future this should be revisited to be able to use a custome tls.Config passed directly in without string parsing/registering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the driver.Connector interface you can skip using string based DSNs
and use a Config object directly with Connector. However the logic to
create the tls.Config is only found in parseDSNParams.
This keeps the string parsing logic in parseDSNParams but moves the tls
generation logic into Config.normalize.
This is still less than ideal since we cannot directly pass in
tls.Config into Config and have it be used, but it is sill backwards
compatible. In the future this should be revisited to be able to use a
custom tls.Config passed directly in without string
parsing/registering.
Checklist