Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mysqlContext #886

Merged
merged 1 commit into from Oct 30, 2018
Merged

Remove mysqlContext #886

merged 1 commit into from Oct 30, 2018

Conversation

methane
Copy link
Member

@methane methane commented Oct 29, 2018 •
edited

It is not needed anymore because we dropped Go 1.7 support

Please explain the changes you made here.

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Remove mysqlContext
162d05e 
It is not needed anymore because we dropped Go 1.7 support
shogo82148
shogo82148 approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane merged commit 64cea2f into go-sql-driver:master Oct 30, 2018
@methane methane deleted the remove-mycontext branch October 30, 2018 13:01
@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@methane @shogo82148 @julienschmidt