Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call markBadConn in Ping method #875

Merged
merged 2 commits into from Oct 19, 2018
Merged

Call markBadConn in Ping method #875

merged 2 commits into from Oct 19, 2018

Conversation

iliacimpoes
Copy link
Contributor

@iliacimpoes iliacimpoes commented Oct 19, 2018 •
edited

Description

Currently connection is not marked as "Bad Connection" in Ping method, so a bad connection is not removed from connection pool.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

julienschmidt
julienschmidt requested changes Oct 19, 2018
View reviewed changes
Copy link
Member

@julienschmidt julienschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Thank you!

Please add yourself to the AUTHORS file, so we can merge the PR.

@julienschmidt julienschmidt added this to the v1.4.1 milestone Oct 19, 2018
@julienschmidt julienschmidt merged commit 0f257fc into go-sql-driver:master Oct 19, 2018
@iliacimpoes
Copy link
Contributor Author

@methane @julienschmidt, thanks for the quick review

@iliacimpoes iliacimpoes deleted the MarkBadConnectionOnPing branch October 22, 2018 08:35
@methane methane mentioned this pull request Feb 20, 2019
Closed
@julienschmidt julienschmidt modified the milestones: v1.4.1, v1.5.0 Jan 3, 2020
@iliacimpoes iliacimpoes mentioned this pull request Nov 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iliacimpoes @methane @julienschmidt