Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to drop Go 1.8 support? #869

Closed
methane opened this issue Oct 15, 2018 · 7 comments · Fixed by #936
Closed

When to drop Go 1.8 support? #869

methane opened this issue Oct 15, 2018 · 7 comments · Fixed by #936
Milestone

Comments

@methane
Copy link
Member

methane commented Oct 15, 2018

README says: "Go 1.8 or higher. We aim to support the 3 latest versions of Go."

Now Go 1.11 is stable. Can we drop Go 1.8 support in master branch?

@julienschmidt
Copy link
Member

If there is a good reason to drop support for Go 1.8: yes.
As long as we didn't introduce any breaking changes, I think we can continue to support it.

@methane
Copy link
Member Author

methane commented Oct 16, 2018

I'm considering to check connection liveness before sending query.
It needs SyscallConn which is introduced in Go 1.8.

If we can drop Go 1.8 support, we can implement it without version tag and stub file for Go 1.8.

@methane
Copy link
Member Author

methane commented Oct 20, 2018

#838 can be merged without version tag hack, too.

@julienschmidt
Copy link
Member

What's the current situation with platforms like AppEngine? Is it safe to drop Go 1.8 by now?

@methane
Copy link
Member Author

methane commented Mar 9, 2019

@julienschmidt
Copy link
Member

It's deprecated but not yet disabled, as it seems.

Anyway, I think removing Go 1.8 support should be fine by now.

@methane
Copy link
Member Author

methane commented Mar 9, 2019

It's deprecated but not yet disabled, as it seems.

Yes, but "no new deployment". It means already deployed Go 1.8 app are still running.
But no one can use new library with Go 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants