Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Go 1.7 Support #823

Merged
merged 5 commits into from Jun 18, 2018
Merged

Drop Go 1.7 Support #823

merged 5 commits into from Jun 18, 2018

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Jun 17, 2018 •
edited

Description

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

julienschmidt
julienschmidt requested changes Jun 18, 2018
View reviewed changes
utils.go Outdated
@@ -724,3 +726,34 @@ func (ae *atomicError) Value() error {
}
return nil
}

func cloneTLSConfig(c *tls.Config) *tls.Config {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also added for backwards-compatibility. Remove the function and use c.Clone directly instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did 6649058

@julienschmidt julienschmidt added this to the v1.5.0 milestone Jun 18, 2018
@julienschmidt julienschmidt merged commit 749ddf1 into go-sql-driver:master Jun 18, 2018
@shogo82148 shogo82148 deleted the drop-go1.7 branch July 2, 2018 04:10
@shogo82148 shogo82148 mentioned this pull request Jun 21, 2019
Closed
@methane methane mentioned this pull request Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shogo82148 @methane @julienschmidt