Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CLIENT_OPTIONAL_RESULTSET_METADATA #1105

Open
ybbct opened this issue May 20, 2020 · 2 comments
Open

Support CLIENT_OPTIONAL_RESULTSET_METADATA #1105

ybbct opened this issue May 20, 2020 · 2 comments
Labels
performance

Comments

@ybbct
Copy link

ybbct commented May 20, 2020

Issue description

This option will improve performance in many scenarios
https://dev.mysql.com/worklog/task/?id=8134

https://www.facebook.com/weixiang.zhai/posts/678596755543802
@julienschmidt
Copy link
Member

The flag is not documented here: https://dev.mysql.com/doc/internals/en/capability-flags.html

According to the "Low Level Design" part of the worklog, the following is used:

#define CLIENT_OPTIONAL_RESULTSET_METADATA (1UL << 25)

Further source: https://dev.mysql.com/doc/refman/8.0/en/c-api-optional-metadata.html

tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
d3d8720 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
b39ccbc 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
@tz70s tz70s mentioned this issue Aug 30, 2020
Open
5 tasks
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
d9cf63e 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
46e70d0 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
b8c3fa7 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
4387f1b 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
9c2dbfb 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Aug 30, 2020
@tz70s
Support optional resultset metadata
89bdedf 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
@Bisstocuz
Copy link

Bisstocuz commented Jul 29, 2021 •
edited

The flag is not documented here: https://dev.mysql.com/doc/internals/en/capability-flags.html

According to the "Low Level Design" part of the worklog, the following is used:

#define CLIENT_OPTIONAL_RESULTSET_METADATA (1UL << 25)

Further source: https://dev.mysql.com/doc/refman/8.0/en/c-api-optional-metadata.html

It's right, this option will improve performance in many scenarios with up to 180% QPS performance improvement.
https://dev.mysql.com/doc/c-api/8.0/en/c-api-optional-metadata.html

Is it possible for github.com/go-sql-driver/mysql to support this feature?

tz70s added a commit to tz70s/mysql that referenced this issue Jan 21, 2022
@tz70s
Support optional resultset metadata
939de8f 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Jan 21, 2022
@tz70s
Support optional resultset metadata
cb6c794 
Allow optional resultset metadata.
Can potentially improve the performance in many scenarios.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Jan 21, 2022
@tz70s
Support optional resultset metadata
acbdeec 
Allow optional resultset metadata.
Can potentially improve the performance in many scenarios.

Issue go-sql-driver#1105
tz70s added a commit to tz70s/mysql that referenced this issue Jan 21, 2022
@tz70s
Support optional resultset metadata
0b7ff91 
Allow optional resultset metadata.
Can potentially improve the performance in many scenarios.

Issue go-sql-driver#1105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@methane @julienschmidt @ybbct @Bisstocuz