Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default protocol to tcp #1074

Open
DavisLinger opened this issue Mar 23, 2020 · 2 comments
Open

set default protocol to tcp #1074

DavisLinger opened this issue Mar 23, 2020 · 2 comments
Labels

Comments

@DavisLinger
Copy link

Issue description

Can tcp of the connection string be set as a default protocol option, which will fix the url standard, we can easily parse out the parameters of the entire connection string, and adding the tcp parameter will cause the entire string to fail to complete according to the url standard Parsing.

Example code

mysql://root:123456@127.0.0.1:3339/ad_base?charset=utf8”

this url can be parsed.but this url can not be parsed because of tcp():

"mysql://root:123456@tcp(127.0.0.1:3339)/ad_base?charset=utf8"

Configuration

*Driver version (or git SHA):latest

*Go version:go 1.12-1.14

*Server version: MySQL 8.0

Server OS: E.g. Mac OS Catalina

@dolmen
Copy link
Contributor

dolmen commented Jun 1, 2020

Use mysql.ParseDSN to parse a DSN.

@methane
Copy link
Member

methane commented May 26, 2023

DSN is not URL. But I think address/db is better than network/db.

But it is breaking change. Currently, unix/db is valid DSN. It means to connecut localhost db with unix socket where the default location.

After changing it, unix/db means tcp(unix:3306)/db. So this is breaking change.
I like the change. I am worried about what everyone will think of the breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants