Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conncheck: build on more supported platforms #1051

Merged
merged 1 commit into from Jan 7, 2020
Merged

conncheck: build on more supported platforms #1051

merged 1 commit into from Jan 7, 2020

Conversation

julienschmidt
Copy link
Member

Description

This makes the connCheck build on more platforms that seem to support it. See #1048 (comment)

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 6, 2020
@julienschmidt julienschmidt mentioned this pull request Jan 6, 2020
Merged
5 tasks
shogo82148
shogo82148 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienschmidt julienschmidt merged commit 4bdaef4 into master Jan 7, 2020
@julienschmidt julienschmidt deleted the conncheck_platforms branch January 7, 2020 07:34
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
conncheck: build on more supported platforms (go-sql-driver#1051)
50f9b4c
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@julienschmidt @tz70s
conncheck: build on more supported platforms (go-sql-driver#1051)
846195b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienschmidt @shogo82148