Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shiori auto increasment not work currectly on sqlite database #892

Closed
Monirzadeh opened this issue Apr 26, 2024 · 1 comment · Fixed by #894
Closed

Shiori auto increasment not work currectly on sqlite database #892

Monirzadeh opened this issue Apr 26, 2024 · 1 comment · Fixed by #894
Labels
component:backend database:sqlite type:bug Something isn't working

Comments

@Monirzadeh
Copy link
Collaborator

Data

  • Shiori version: 1.6.2
  • Database Engine: sqlite
  • Operating system: linux
  • CLI/Web interface/Web Extension: all of them

Describe the bug / actual behavior

if you add just first bookmark it will get ID 1
now if you remove that bookmark and add new bookmark it again get same ID number 1

Expected behavior

shiori always should create uniq id that not ever use.

To Reproduce

Steps to reproduce the behavior:

  1. add bookmark a that you will get id 1 for that
  2. delete that bookmark
  3. add bookmark b
  4. you will get id 1 again instead of 2 for bookmark b

Notes

it happen just in sqlite
@fmartingr
Copy link
Member

Related documentation: https://www.sqlite.org/autoinc.html

This was referenced Apr 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:backend database:sqlite type:bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sqlite): id column should be unique Monirzadeh/shiori
2 participants
@fmartingr @Monirzadeh