Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiori print command or API doesn't return the thumbnail url #838

Open
brunoamaral opened this issue Feb 7, 2024 · 1 comment
Open

shiori print command or API doesn't return the thumbnail url #838

brunoamaral opened this issue Feb 7, 2024 · 1 comment
Labels
type:bug Something isn't working

Comments

@brunoamaral
Copy link

Data

  • Shiori version: v1.6.0-rc.7
  • Database Engine: sqlite
  • Operating system: ubuntu
  • CLI/Web interface/Web Extension: CLI

Describe the bug / actual behavior

Maybe this is actually the expected behaviour, but running shiori print -j doesn't show a value for imageURL. It only returns ID, url, title, excerpt, public, modified, hasContent, tags, hasArchive, hasEbook, create_archive, and create_ebook.

Expected behavior

Any value for the imageUrl.

To Reproduce

shiori print -j or visit api/v1/bookmarks/

Screenshots

Notes

@brunoamaral brunoamaral added the type:bug Something isn't working label Feb 7, 2024
@fmartingr
Copy link
Member

Investigation note: I checked this briefly today and the problem is that the old API filled the DTO model with all required field. We need to move this logic into the BookmarksDomain and use that from the API and the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants