Cannot unmarshal ISO-8859-1 encoded XML

[mjeco]

Trying to use the automatic unmarshaling of XML with SetResult() is failing for me as the XML in the response has encoding="ISO-8859-1" set.

Fails with the following error:

xml: encoding "ISO-8859-1" declared but Decoder.CharsetReader is nilexit status 1

Response example:

<?xml version="1.0" encoding="ISO-8859-1"?>
<Response stat="200" code="ok">
  <Success>
    <Data>
      <commands>
        <cmd>get</cmd>
        <cmd>set</cmd>
      <commands>
    </Data>
  </Success>
</Response>

I am able to successfully unmarshal the above XML response with the below function.

import (
  "golang.org/x/net/html/charset"
)

func UnmarshalXML(data []byte, result interface{}) error {
	decoder := xml.NewDecoder(bytes.NewReader(data))
	decoder.CharsetReader = charset.NewReaderLabel
	err := decoder.Decode(&result)
	return err
}

Is it possible to set the CharsetReader to be used for the XML unmarshal?

[mjeco]

I got it to work by updating the utils.Unmarshalc function as follows.

import (
+    "golang.org/x/net/html/charset"
)

func Unmarshalc(c *Client, ct string, b []byte, d interface{}) (err error) {
	if IsJSONType(ct) {
		err = c.JSONUnmarshal(b, d)
	} else if IsXMLType(ct) {
+             decoder := xml.NewDecoder(bytes.NewReader(b))
+             if strings.Contains(string(b), "encoding=\"ISO-8859-1\"") {
+                   decoder.CharsetReader = charset.NewReaderLabel
+             }
+             err = decoder.Decode(d)
-              err = xml.Unmarshal(b, d)
	}

	return
}

Is this something that could be added to the code ?

[jeevatkm]

@mjeco I think, it's better to expose XML marshal & unmarshal for the override similar to JSON. So that resty user can inject the custom function.
FYI, doing bytes -> string, and string comparing may not be performant.

[jeevatkm]

@mjeco After v2.7.0 release, you can do as following. Also charset string condition may not be needed.

client := resty.New()

client.XMLUnmarshal = func(data []byte, v interface{}) error {
   decoder := xml.NewDecoder(bytes.NewReader(data))
   decoder.CharsetReader = charset.NewReaderLabel
   err = decoder.Decode(v)
}

[mjeco]

@jeevatkm Allowing to set a custom unmarshal function for XML is the best path forward. Thanks for this!