Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing SetScheme option side effects on schemeless Host URL #407 #460

Merged
merged 2 commits into from Sep 16, 2021

Conversation

jeevatkm
Copy link
Member

Closes #407

@jeevatkm jeevatkm added bug v2 For resty v2 labels Sep 14, 2021
@jeevatkm jeevatkm added this to the v2.7.0 Milestone milestone Sep 14, 2021
@jeevatkm jeevatkm self-assigned this Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #460 (18ff59d) into master (79cc4d4) will increase coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   96.82%   96.89%   +0.07%     
==========================================
  Files          10       10              
  Lines        1322     1321       -1     
==========================================
  Hits         1280     1280              
+ Misses         24       23       -1     
  Partials       18       18              
Impacted Files Coverage Δ
middleware.go 92.85% <0.00%> (+0.33%) ⬆️
client.go 97.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79cc4d4...18ff59d. Read the comment docs.

@jeevatkm jeevatkm merged commit 1792d62 into master Sep 16, 2021
@jeevatkm jeevatkm deleted the for-gh318-gh407 branch October 24, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

client SetScheme and SetHostURL causing the hostname to be invalid
1 participant