feat(#432): Implement Easier Adding of Multiple Value HTTP Header #452
Conversation
…ader Implement easier adding of multiple value HTTP Header with function `SetMultiValueHeaders`
|
@mhdiiilham Thank you for your PR appreciated, I'm sorry for the delayed response. Please check the review comment. |
Hi, yes I updated the method name |
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 96.06% 96.85% +0.79%
==========================================
Files 10 10
Lines 1041 1304 +263
==========================================
+ Hits 1000 1263 +263
Misses 23 23
Partials 18 18
Continue to review full report at Codecov.
|
| // "Accept": []string{"text/html", "application/xhtml+xml", "application/xml;q=0.9", "image/webp", "*/*;q=0.8"}, | ||
| // }) | ||
| // Also you can override header value, which was set at client instance level. | ||
| func (r *Request) SetHeaderMultiValues(headers map[string][]string) *Request { |
There was a problem hiding this comment.
@mhdiiilham @rizalgowandy FYI, godoc is not updated with the updated method name. I will be doing that. Thanks.
There was a problem hiding this comment.
oh yeah, I'm sorry I missed the godoc comment. Thank you @jeevatkm
There was a problem hiding this comment.
@mhdiiilham No worries, I just did. Maybe next time 👍
Implement easier adding of multiple value HTTP Header with function
SetMultiValueHeadersCloses #432