Update Bazel build to work with 4.0.0 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes several updates to the BUILD and WORKSPACE files, so that they now work with Bazel 4.0.0, Gazelle 0.23 and rules_go 0.27. By default, [Gazelle now uses](bazelbuild/bazel-gazelle#863) the last component of the Bazel package, rather than `go_default_library` as the `go_library name`. This causes problems when the naming conventions do not match. bazelbuild/bazel-gazelle#890 (comment) Adding support for the new naming convention should not break anything that depends on using the old naming convention, because the Gazelle option `import_alias` makes aliases to the libraries and this allows the old naming convention to still work.
|
@tanyabouman Thank you for your PR appreciated, I'm sorry for the delayed response. Travis CI build link was broken. I have migrated travis-ci.org to travis-ci.com Can you please edit the PR to trigger the CI build? |
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 96.06% 96.85% +0.79%
==========================================
Files 10 10
Lines 1041 1304 +263
==========================================
+ Hits 1000 1263 +263
Misses 23 23
Partials 18 18
Continue to review full report at Codecov.
|
jeevatkm
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several updates to the BUILD and WORKSPACE files, so that they now work with Bazel 4.0.0, Gazelle 0.23 and rules_go 0.27.
By default, Gazelle now uses the last component of the Bazel package, rather than
go_default_libraryas thego_library name.This causes problems when the naming conventions do not match.
bazelbuild/bazel-gazelle#890 (comment)
Adding support for the new naming convention should not break anything that depends on using the old naming convention, because the Gazelle option
import_aliasmakes aliases to the libraries and this allows the old naming convention to still work.