Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query args to instrumentation #314

Merged
merged 3 commits into from Oct 15, 2022
Merged

Conversation

wakamenod
Copy link
Contributor

I think it would be useful to have query parameters in the log output as well.
What do you think?

@Fs02
Copy link
Member

Fs02 commented Oct 9, 2022

looks like a breaking change 🤔

can you give some of your example requirements?

@wakamenod
Copy link
Contributor Author

@Fs02

Hi, thanks for checking out.

can you give some of your example requirements?

Well, I think other ORM libraries such as gorm can output query log with parameters,
and from my experience that was useful when you debug the application.

@Fs02
Copy link
Member

Fs02 commented Oct 10, 2022

hmmm, fair enough

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (dd9c330) compared to base (001ce33).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #314   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         2766      2766           
=========================================
  Hits          2766      2766           
Impacted Files Coverage Δ
instrumentation.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Fs02 Fs02 merged commit eaad046 into go-rel:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants