Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do takes a context as its first argument #295

Merged
merged 1 commit into from Jun 22, 2022
Merged

Conversation

youpy
Copy link
Contributor

@youpy youpy commented Jun 22, 2022

related: go-rel/migration#9

Currently, Do cannot run under the transaction scope of a migration, so it cannot access schemas that have been updated by other migrations.

To solve this, allow the context to be passed as the first argument of Do.

Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

(although the build is not pass, I need to merge this first before updating https://github.com/go-rel/migration package)

@Fs02 Fs02 merged commit 8347a7d into go-rel:master Jun 22, 2022
@youpy youpy deleted the do-ctx branch June 23, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants