Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in comments #248

Merged
merged 2 commits into from Nov 4, 2021
Merged

fix typo in comments #248

merged 2 commits into from Nov 4, 2021

Conversation

nalxnet
Copy link
Contributor

@nalxnet nalxnet commented Nov 4, 2021

I stubled across these typos/errors while reading the documentation: https://go-rel.github.io/reference/where/

Possibly needs to be fixed in other places, depending on how the docs are created.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #248 (6da97fb) into master (05de4f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3969      3969           
=========================================
  Hits          3969      3969           
Impacted Files Coverage Δ
filter_query.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05de4f0...6da97fb. Read the comment docs.

@Fs02
Copy link
Member

Fs02 commented Nov 4, 2021

Possibly needs to be fixed in other places, depending on how the docs are created.

related docs in website is auto generated in this repo: https://github.com/go-rel/doc
this fix should be enough

Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 👍

@Fs02 Fs02 merged commit cbcbfd4 into go-rel:master Nov 4, 2021
@nalxnet nalxnet deleted the fix/typo branch November 4, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants