Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to find records to collection of pointer type #246

Merged
merged 4 commits into from Nov 4, 2021

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 3, 2021

Fixes #242

I'm not very familiar with how reflect is built as I have barely used it in past and still not too familiar with go-rel internals but this is what I got through trial and error 馃槃

At least seems to be working now

@lafriks lafriks added the bug Something isn't working label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #246 (f98547f) into master (c0caf3d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3958      3969   +11     
=========================================
+ Hits          3958      3969   +11     
Impacted Files Coverage 螖
collection.go 100.00% <100.00%> (酶)
document.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c0caf3d...f98547f. Read the comment docs.

@lafriks lafriks requested a review from Fs02 November 3, 2021 21:18
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks
if possible, let me know if you've tested this in project and found no problem, will release it after that

@Fs02 Fs02 merged commit 05de4f0 into go-rel:master Nov 4, 2021
@lafriks lafriks deleted the fix/arr_pointer branch November 4, 2021 07:13
@lafriks
Copy link
Contributor Author

lafriks commented Nov 4, 2021

Will test it and let you know

@lafriks
Copy link
Contributor Author

lafriks commented Nov 5, 2021

Tested in my project and seems to be working just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindAll panics with array poiner type
2 participants